From ce845a7bafba7b082f7474d74bbd395dbe6db0b5 Mon Sep 17 00:00:00 2001 From: Dimitris Karvounis <1+jimkarvo@jksoftware.gr> Date: Thu, 3 Sep 2026 11:09:03 +0000 Subject: [PATCH] fix: review_requested uses normalized reviewers (fixes PR 184 slack notification) --- internal/event/processor.go | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/internal/event/processor.go b/internal/event/processor.go index bbdad4a..7665000 100644 --- a/internal/event/processor.go +++ b/internal/event/processor.go @@ -114,15 +114,20 @@ func (p *Processor) HandlePullRequest(e *webhook.PullRequestEvent) { case "review_requested": event.Type = TypePRReviewRequested - // Notify newly requested reviewers (array) - if len(e.RequestedReviewers) > 0 { - for _, reviewer := range e.RequestedReviewers { - p.logger.Debug().Str("requested_reviewer", reviewer.Login).Msg("review_requested event") + if len(event.Reviewers) > 0 { + for _, u := range event.Reviewers { + p.logger.Debug().Str("requested_reviewer", u.GiteaUsername).Msg("review_requested event") usersToNotify = append(usersToNotify, struct { user User reason NotificationReason - }{giteaUserToUser(reviewer), ReasonReviewer}) + }{u, ReasonReviewer}) } + } else if e.RequestedReviewer != nil { + p.logger.Debug().Str("requested_reviewer", e.RequestedReviewer.Login).Msg("review_requested event") + usersToNotify = append(usersToNotify, struct { + user User + reason NotificationReason + }{giteaUserToUser(*e.RequestedReviewer), ReasonReviewer}) } else { p.logger.Debug().Msg("review_requested event but no RequestedReviewers field") }